Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for support of AWS SigV4 authorization in Dashboards Data Sources UI #2942

Merged
merged 11 commits into from
Feb 23, 2023
Merged

Add documentation for support of AWS SigV4 authorization in Dashboards Data Sources UI #2942

merged 11 commits into from
Feb 23, 2023

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Feb 17, 2023 •
edited
Loading

Description

The Data Sources window now supports AWS SigV4 authorization for connecting to data sources.

Issues Resolved

This adds documentation to cover AWS SigV4 authorization options in Data Sources for Dashboards.
Fixes #2667

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum
fix#2667-sigv4-authz
d515e56 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum added dashboards 2 - In progress Issue/PR: The issue or PR is in progress. v2.6.0 labels Feb 17, 2023
@cwillum cwillum added this to the 2023-Q1 milestone Feb 17, 2023
@cwillum cwillum self-assigned this Feb 17, 2023
@cwillum cwillum requested a review from a team as a code owner February 17, 2023 00:42
@cwillum
fix#2667-sigv4-authz
32e661f 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
fix#2667-sigv4-authz
776cbec 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
fix#2667-sigv4-authz
001d11b 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
fix#2667-sigv4-authz
a90f069 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
fix#2667-sigv4-authz
83ea255 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
fix#2667-sigv4-authz
16aefe0 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Feb 18, 2023
@cwillum
fix#2667-sigv4-authz
318315d 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
fix#2667-sigv4-authz
9d9bb5e 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@hdhalter hdhalter added the release-notes PR: Include this PR in the automated release notes label Feb 21, 2023
@zhongnansu zhongnansu self-requested a review February 21, 2023 22:22
zhongnansu
zhongnansu approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

@cwillum cwillum added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Feb 22, 2023
hdhalter
hdhalter approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much to find fault with here! Looks good.

_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
ariamarble
ariamarble approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left wording and format changes as per Dashboards UI guides. Let me know if you have any questions. Thanks!

_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
@cwillum
fix#2667-sigv4-authz
9dcff5e 
Signed-off-by: cwillum <cwmmoore@amazon.com>
natebower
natebower reviewed Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillum Please see my comments and changes and let me know if you have any questions. Thanks!

_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
@cwillum
fix#2667-sigv4-authz
94efdf8 
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum removed the 4 - Doc review PR: Doc review in progress label Feb 23, 2023
@cwillum cwillum merged commit 9a729cb into main Feb 23, 2023
@cwillum cwillum deleted the fix#2667-datasource-sigv4-authz branch February 23, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@zhongnansu zhongnansu zhongnansu approved these changes

@hdhalter hdhalter hdhalter approved these changes

@ariamarble ariamarble ariamarble approved these changes

Assignees

@cwillum cwillum

Labels
dashboards experimental release-notes PR: Include this PR in the automated release notes v2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Document a new SigV4 authentication type in Dashboards Multiple Datasource
5 participants
@cwillum @zhongnansu @natebower @hdhalter @ariamarble