Adds documentation for security demo configuration setup #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki and
natebower
as code owners
DarshitChanpura
commented
Jan 8, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
|
Looks like this PR - #5887 - has some of these changes. @Naarcha-AWS - can you either close one or reconcile the two files to make sure we have all the required changes? Thanks! |
hdhalter
reviewed
Jan 8, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
1 task
natebower
reviewed
Jan 16, 2024
There was a problem hiding this comment.
@Naarcha-AWS Please see my comments and changes and let me know if you have any questions. Thanks!
Naarcha-AWS
reviewed
Jan 16, 2024
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
added
6 - Done but waiting to merge
|
@Naarcha-AWS I see that you moved this back to Final Editorial Review, anything needed from my end? |
hdhalter
added
the
release-notes
Merged
1 task
|
@natebower Could I get your re-review on this? |
I think you meant to tag @Naarcha-AWS ? |
Yes, confirmed with @Naarcha-AWS that this does not require my re-review. |
2 tasks
hdhalter
added
3 - Done
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds section for setting up security plugin's demo configuration.
Related PR: opensearch-project/project-website#2526
Issues Resolved
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.