Add unsupported warning for local models #6489
Conversation
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
kolchfa-aws
requested review from
hdhalter,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower and
dlvenable
as code owners
|
@ylwu-amzn @bbarani @peterzhuamazon Added this warning per the release PR. Please review when you get a chance. |
| @@ -19,6 +19,9 @@ To integrate machine learning (ML) models into your OpenSearch cluster, you can | |||
|
|
|||
| - **Custom models** such as PyTorch deep learning models: To learn more, see [Custom models]({{site.url}}{{site.baseurl}}/ml-commons-plugin/custom-local-models/). | |||
|
|
|||
| OpenSearch does not support running local models on the CentOS 7 operating system. Moreover, not all local models can run on all hardware and operating systems. | |||
There was a problem hiding this comment.
I don't think we should generalize this to OpenSearch rather to ml-commons plugin. Is this OpenSearch limitation or ml-commons plugin limitation?
There was a problem hiding this comment.
Good point, this should be ml-commons plugin
There was a problem hiding this comment.
I'm open to changing to ML Commons, however, in general, we do not mention plugins in the documentation, and since there is no other way to run models in OpenSearch, maybe keeping it general is OK. @bbarani @ylwu-amzn Let me know your thoughts.
There was a problem hiding this comment.
I see! Its just that we explicitly mention that we support CentOS 7 for OpenSearch here and this statement contradicts it.
There was a problem hiding this comment.
OK, let me make it more generic by using passive voice instead of mentioning the plugin.
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
* Add unsupported warning for local models Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Reword to be more generic Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> (cherry picked from commit 76c2ed0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add unsupported warning for local models * Reword to be more generic --------- (cherry picked from commit 76c2ed0) Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add unsupported warning for local models Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> * Reword to be more generic Signed-off-by: Fanit Kolchina <kolchfa@amazon.com> --------- Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Added a disclaimer that local models don't support CentOS 7 and all hardware/OS based on this comment.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.