Removing outdated limitations in Searchable Snapshots describing KNN is not compatible. #8817
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ctopus13prime
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
navneet1v
reviewed
Nov 26, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/searchable_snapshot.md
Show resolved
Hide resolved
0ctopus13prime
force-pushed
the
searchable-snapshot-knn
branch
from
8855962
to
1b42369
Compare
navneet1v
reviewed
Nov 26, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/searchable_snapshot.md
Outdated
Show resolved
Hide resolved
…is not compatible. Since 2.18, searchable snapshots is available with KNN Signed-off-by: Dooyong Kim <kdooyong@amazon.com>
0ctopus13prime
force-pushed
the
searchable-snapshot-knn
branch
from
1b42369
to
9151da8
Compare
|
@0ctopus13prime Is this PR ready for doc review? |
yes it is |
kolchfa-aws
reviewed
Dec 2, 2024
_tuning-your-cluster/availability-and-recovery/snapshots/searchable_snapshot.md
Outdated
Show resolved
Hide resolved
kolchfa-aws
approved these changes
Dec 2, 2024
…hable_snapshot.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Doo Yong Kim <0ctopus13prime@gmail.com>
|
@kolchfa-aws |
natebower
approved these changes
Dec 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…is not compatible. (#8817) * Removing outdated limitations in Searchable Snapshots describing KNN is not compatible. Since 2.18, searchable snapshots is available with KNN Signed-off-by: Dooyong Kim <kdooyong@amazon.com> * Update _tuning-your-cluster/availability-and-recovery/snapshots/searchable_snapshot.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Doo Yong Kim <0ctopus13prime@gmail.com> --------- Signed-off-by: Dooyong Kim <kdooyong@amazon.com> Signed-off-by: Doo Yong Kim <0ctopus13prime@gmail.com> Co-authored-by: Dooyong Kim <kdooyong@amazon.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit 05d4125) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since 2.18, now snapshot supports KNN index. Hence removing the comments saying KNN index is not supported.
Issues Resolved
opensearch-project/k-NN#2033
Version
2.18
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.