Remove Demo Classes, add No-Op Step #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
============================================
+ Coverage 66.71% 67.09% +0.37%
- Complexity 272 276 +4
============================================
Files 34 35 +1
Lines 1322 1319 -3
Branches 125 125
============================================
+ Hits 882 885 +3
+ Misses 395 390 -5
+ Partials 45 44 -1
|
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
approved these changes
Oct 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Remove Demo Classes, add No-Op Step Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add test coverage Signed-off-by: Daniel Widdis <widdis@gmail.com> * Revert enum javadocs as they are handled by #119 Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 9dffc0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Oct 31, 2023
Remove Demo Classes, add No-Op Step (#129) * Remove Demo Classes, add No-Op Step * Add test coverage * Revert enum javadocs as they are handled by #119 --------- (cherry picked from commit 9dffc0a) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
demopackage, since it no longer works and future development has made it obsolete.Adds a new
NoOpStepworkflow step that does nothing, useful for the case of a synchronizing node as well as testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.