[Feature/agent_framework] Added Retry functionality for Deploy Model #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
reviewed
Dec 4, 2023
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/workflow/RegisterLocalModelStepTests.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
retry-deploy
branch
from
4b498bd to
528a3e1
Compare
amitgalitz
reviewed
Dec 4, 2023
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
amitgalitz
approved these changes
Dec 4, 2023
joshpalis
approved these changes
Dec 5, 2023
owaiskazi19
merged commit 9387167
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…pensearch-project#245) * Added retry functionality for DeployModel Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed timeout and exception issues Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR Comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…pensearch-project#245) * Added retry functionality for DeployModel Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed timeout and exception issues Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR Comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
…245) * Added retry functionality for DeployModel Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed timeout and exception issues Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR Comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…pensearch-project#245) * Added retry functionality for DeployModel Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed timeout and exception issues Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR Comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
…245) * Added retry functionality for DeployModel Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed timeout and exception issues Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR Comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to test: #238 (comment)
Issues Resolved
Closes #238
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.