-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change thread queue to 100 and fix headers parsing bug #265
Merged
amitgalitz
merged 1 commit into
opensearch-project:feature/agent_framework
from
amitgalitz:thread-fix
Dec 12, 2023
Merged
Change thread queue to 100 and fix headers parsing bug #265
amitgalitz
merged 1 commit into
opensearch-project:feature/agent_framework
from
amitgalitz:thread-fix
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
jackiehanyang
as code owners
December 9, 2023 00:03
What does this mean? Does it fail silently? I thought an ExecutorService just blocked until a thread was available, in which case these should eventually time out, right? Or am I missing something? |
dbwiddis
approved these changes
Dec 9, 2023
28 tasks
Attaching this related issue : #61 |
joshpalis
approved these changes
Dec 11, 2023
amitgalitz
merged commit Dec 12, 2023
bde10f5
into
opensearch-project:feature/agent_framework
10 checks passed
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…oject#265) change thread queue to 100 and fix headers bug Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…oject#265) change thread queue to 100 and fix headers bug Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
change thread queue to 100 and fix headers bug Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…oject#265) change thread queue to 100 and fix headers bug Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
change thread queue to 100 and fix headers bug Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the provision thread queue to 100. This is because currently the size queue of 10 is too low. Basically right now if all the threads are busy and If an 11th request comes, the request will be just lost completely if we have no extra queue or re-route logic of our own. Currently we have no extra re-route logic but I think expanding the queue to a size of 100 to allow more provisioning should be sufficient for now. We should probably come back to this after doing more intense load testing.
I also additionally added a StringToObjectMap parser and builder so we can handle cases where we encounter an Object[] that these objects can be either be Map<String, String> or Map<String, Map<String, String>> like in the case of create connector actions
I tested manually through API calls, however I didn't add a UT for the StringToObject because I didn't want to use reflection to check the object type here, since its a generic object.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.