Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resources_created with deploy model: #275

Conversation

amitgalitz
Copy link
Member

@amitgalitz amitgalitz commented Dec 12, 2023

Description

Added update to include deploy model in resources created list. This is needed for de-provisioning to work correctly. Future enhancement could be made if confusion is stated by users on both deploy and register model being under resources created.

Example response:

{
    "workflow_id": "G513W4wBRItvelfmy_w4",
    "state": "COMPLETED",
    "provisioning_progress": "DONE",
    "provision_start_time": 1702341633430,
    "provision_end_time": 1702341639045,
    "resources_created": [
        {
            "workflow_step_name": "register_agent",
            "workflow_step_id": "sub_agent",
            "agent_id": "HJ13W4wBRItvelfm5fyw"
        },
        {
            "workflow_step_name": "create_connector",
            "workflow_step_id": "openAI_connector",
            "connector_id": "HZ13W4wBRItvelfm5vzf"
        },
        {
            "workflow_step_name": "register_remote_model",
            "workflow_step_id": "gpt-3.5-model",
            "model_id": "H513W4wBRItvelfm5_xS"
        },
        {
            "workflow_step_name": "deploy_model",
            "workflow_step_id": "deployed-gpt-3.5-model",
            "model_id": "H513W4wBRItvelfm5_xS"
        },
        {
            "workflow_step_name": "register_agent",
            "workflow_step_id": "root_agent",
            "agent_id": "IZ13W4wBRItvelfm-_xt"
        }
    ]
}

Issues Resolved

resolves #272

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to get this merged and unblock me. however I have two questions for educational/future-PR reference.

Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to unblock @dbwiddis

@amitgalitz amitgalitz merged commit fa96284 into opensearch-project:feature/agent_framework Dec 12, 2023
10 checks passed
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
add deploy model resource

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
add deploy model resource

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis pushed a commit that referenced this pull request Dec 18, 2023
add deploy model resource

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
add deploy model resource

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis pushed a commit that referenced this pull request Dec 18, 2023
add deploy model resource

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants