-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resources_created with deploy model: #275
Merged
amitgalitz
merged 1 commit into
opensearch-project:feature/agent_framework
from
amitgalitz:deploy_status
Dec 12, 2023
Merged
Update resources_created with deploy model: #275
amitgalitz
merged 1 commit into
opensearch-project:feature/agent_framework
from
amitgalitz:deploy_status
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
jackiehanyang
as code owners
December 12, 2023 00:44
dbwiddis
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to get this merged and unblock me. however I have two questions for educational/future-PR reference.
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
joshpalis
reviewed
Dec 12, 2023
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
joshpalis
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to unblock @dbwiddis
amitgalitz
merged commit Dec 12, 2023
fa96284
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
add deploy model resource Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
add deploy model resource Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
add deploy model resource Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
add deploy model resource Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
add deploy model resource Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added update to include deploy model in resources created list. This is needed for de-provisioning to work correctly. Future enhancement could be made if confusion is stated by users on both deploy and register model being under resources created.
Example response:
Issues Resolved
resolves #272
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.