-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/agent_framework] Adding installed plugins validation #290
Merged
dbwiddis
merged 5 commits into
opensearch-project:feature/agent_framework
from
joshpalis:plugin
Dec 15, 2023
Merged
[Feature/agent_framework] Adding installed plugins validation #290
dbwiddis
merged 5 commits into
opensearch-project:feature/agent_framework
from
joshpalis:plugin
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
December 14, 2023 20:02
22 tasks
Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! First pass, some suggestions.
src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowProcessSorter.java
Show resolved
Hide resolved
dbwiddis
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, suggestions above remain suggestions for consideration but OK as is.
joshpalis
changed the title
[Feature/agent_framework] Adding installed plugins validation when provisioning
[Feature/agent_framework] Adding installed plugins validation
Dec 14, 2023
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
merged commit Dec 15, 2023
6053594
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…arch-project#290) * Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…arch-project#290) * Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…arch-project#290) * Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…arch-project#290) * Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…arch-project#290) * Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Adding installed plugins validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding failure success unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Combining graph and installed plugin validation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing stray comment Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new field
required_plugins
to theworkflow_step
json which is used to determine if the workflow step's corresponding plugin is currently installed within the local node. Additionally, this PR adds validation whencreating
(with validation) andprovisioning
to check if the given graph has all the required plugins prior to executing.The following example uses a create connector node with an intentionally modified required plugin named
test-plugin
to demonstrate how the validation works :Creating the workflow :
Provisioning the workflow results in an error that states that the
create_connector
step requires thetest-plugin
to be installedIssues Resolved
#126
Part of #88
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.