-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delete Workflow API #294
Merged
dbwiddis
merged 1 commit into
opensearch-project:feature/agent_framework
from
dbwiddis:delete-workflow
Dec 15, 2023
Merged
Add Delete Workflow API #294
dbwiddis
merged 1 commit into
opensearch-project:feature/agent_framework
from
dbwiddis:delete-workflow
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
December 14, 2023 21:29
dbwiddis
force-pushed
the
delete-workflow
branch
2 times, most recently
from
December 15, 2023 01:24
f58d539
to
2fc78a4
Compare
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
force-pushed
the
delete-workflow
branch
from
December 15, 2023 01:50
2fc78a4
to
de66ace
Compare
joshpalis
approved these changes
Dec 15, 2023
dbwiddis
merged commit Dec 15, 2023
fe8339b
into
opensearch-project:feature/agent_framework
10 checks passed
This was referenced Dec 15, 2023
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an API to delete a workflow.
It might be a good idea to warn users about losing track of provisioned resources and allow a "force" param. However, there are many more issues associated with resources (overwriting, etc.) and I think such extra logic belongs in an overall new strategy to handle this, so for now it's just a plain vanilla delete.
Issues Resolved
Fixes #23
Part of overall meta issue #88
Interactive testing
Without feature flag enabled (note this reqiures reading the workflow_id param, see #292):
Enabled feature flag but no templates created:
Create a template, id qU00aowBH9rhI2IwnrH3
Delete it:
Try to delete it again (it's not there):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.