[Backport 2.x] Updated Workflow Interface #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Updated Workflow Interface Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Updated method definition to handle input/output Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 0f0b65d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #34 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 2
Lines ? 4
Branches ? 0
=====================================
Hits ? 0
Misses ? 4
Partials ? 0 |
dbwiddis
approved these changes
Sep 13, 2023
dbwiddis
added a commit
that referenced
this pull request
Sep 28, 2023
#47) * Add WorkflowStepFactory class Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add XContent classes representing Template JSON Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add parse methods for the Template XContent Signed-off-by: Daniel Widdis <widdis@gmail.com> * Cleanup parsing, javadocs, and demo output Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor to use field name constants, get tests working again Signed-off-by: Daniel Widdis <widdis@gmail.com> * Separate WorkflowNode and ProcessNode functionality Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix demos to align with template field names Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add workflow, node, and edge tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add Template tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor TemplateParser to WorkflowProcessSorter Signed-off-by: Daniel Widdis <widdis@gmail.com> * Test exceptional cases Signed-off-by: Daniel Widdis <widdis@gmail.com> * Finish up exceptional cases Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix a template field name bug in demo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase with #34 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase changes from #54 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Integrate thread pool executor service Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix flaky ProcessNodeTests by removing orTimeout Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase and refactor with #44 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix demos and remove DataDemo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Use non-deprecated mapping method for CreateIndexStep Signed-off-by: Daniel Widdis <widdis@gmail.com> * Eliminate casting and deprecation warnings on test classes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove unused/leftover demo class Signed-off-by: Daniel Widdis <widdis@gmail.com> * Typo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't offer steps as an alternative to nodes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move Workflow into package with all the other parsing classes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move process sequencing classes into workflow package Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add PipelineProcessor class and XContent parsing, rename package Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
#47) * Add WorkflowStepFactory class Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add XContent classes representing Template JSON Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add parse methods for the Template XContent Signed-off-by: Daniel Widdis <widdis@gmail.com> * Cleanup parsing, javadocs, and demo output Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor to use field name constants, get tests working again Signed-off-by: Daniel Widdis <widdis@gmail.com> * Separate WorkflowNode and ProcessNode functionality Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix demos to align with template field names Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add workflow, node, and edge tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add Template tests Signed-off-by: Daniel Widdis <widdis@gmail.com> * Refactor TemplateParser to WorkflowProcessSorter Signed-off-by: Daniel Widdis <widdis@gmail.com> * Test exceptional cases Signed-off-by: Daniel Widdis <widdis@gmail.com> * Finish up exceptional cases Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix a template field name bug in demo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase with #34 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase changes from #54 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Integrate thread pool executor service Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix flaky ProcessNodeTests by removing orTimeout Signed-off-by: Daniel Widdis <widdis@gmail.com> * Rebase and refactor with #44 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Fix demos and remove DataDemo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Use non-deprecated mapping method for CreateIndexStep Signed-off-by: Daniel Widdis <widdis@gmail.com> * Eliminate casting and deprecation warnings on test classes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove unused/leftover demo class Signed-off-by: Daniel Widdis <widdis@gmail.com> * Typo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't offer steps as an alternative to nodes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move Workflow into package with all the other parsing classes Signed-off-by: Daniel Widdis <widdis@gmail.com> * Move process sequencing classes into workflow package Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add PipelineProcessor class and XContent parsing, rename package Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 734f9c2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Sep 28, 2023
…Template Parsing (#60) Add WorkflowStep Factory and implement XContent-based Template Parsing (#47) * Add WorkflowStepFactory class * Add XContent classes representing Template JSON * Add parse methods for the Template XContent * Cleanup parsing, javadocs, and demo output * Refactor to use field name constants, get tests working again * Separate WorkflowNode and ProcessNode functionality * Fix demos to align with template field names * Add workflow, node, and edge tests * Add Template tests * Refactor TemplateParser to WorkflowProcessSorter * Test exceptional cases * Finish up exceptional cases * Fix a template field name bug in demo * Rebase with #34 * Rebase changes from #54 * Integrate thread pool executor service * Fix flaky ProcessNodeTests by removing orTimeout * Rebase and refactor with #44 * Fix demos and remove DataDemo * Use non-deprecated mapping method for CreateIndexStep * Eliminate casting and deprecation warnings on test classes * Remove unused/leftover demo class * Typo * Don't offer steps as an alternative to nodes * Move Workflow into package with all the other parsing classes * Move process sequencing classes into workflow package * Add PipelineProcessor class and XContent parsing, rename package --------- (cherry picked from commit 734f9c2) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0f0b65d from #30.