Use Transport Request #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage of deprecated BaseNodeRequest Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
============================================
+ Coverage 84.85% 85.13% +0.28%
- Complexity 319 320 +1
============================================
Files 44 44
Lines 1063 1063
Branches 86 86
============================================
+ Hits 902 905 +3
+ Misses 126 124 -2
+ Partials 35 34 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
navneet1v
reviewed
Oct 12, 2022
|
As part of this OpenSearch issue opensearch-project/OpenSearch#2747 BaseNodeRequest class is removed in 3.0 and deprecated in 2.x . Use TransportRequest which was super class for BaseNodeRequest as an alternative. |
heemin32
approved these changes
Oct 13, 2022
martin-gaievski
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove usage of deprecated BaseNodeRequest
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.