Added input parameter validation with few small changes #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
============================================
+ Coverage 88.43% 88.58% +0.15%
- Complexity 746 752 +6
============================================
Files 91 92 +1
Lines 2697 2708 +11
Branches 215 218 +3
============================================
+ Hits 2385 2399 +14
+ Misses 232 230 -2
+ Partials 80 79 -1
|
junqiu-lei
reviewed
Jul 27, 2023
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/action/DeleteDatasourceRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/common/InputFormatValidator.java
Outdated
Show resolved
Hide resolved
junqiu-lei
approved these changes
Jul 27, 2023
1. Added datasource name validation in delete/update api 2. Added datasource name validation in processor creation method 3. Changed index name delimiter from `.` to `-` to be consistent with others Signed-off-by: Heemin Kim <heemin@amazon.com>
| for (Map.Entry<String, String> entry : nameToError.entrySet()) { | ||
|
|
||
| // Run | ||
| System.out.println(entry.getKey()); |
There was a problem hiding this comment.
Oops. Added by mistake.
martin-gaievski
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.to-to be consistent with othersIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.