[Backport 2.x] Changes in invalid input handling #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
1. Switch exception type from OpenSearchException to IllegalArgumentException for invalid endpoint 2. Add cluster state validation for update API Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit e1f41bb)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
heemin32
approved these changes
Jul 31, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #375 +/- ##
============================================
- Coverage 88.50% 88.49% -0.02%
- Complexity 746 751 +5
============================================
Files 91 92 +1
Lines 2697 2711 +14
Branches 215 220 +5
============================================
+ Hits 2387 2399 +12
- Misses 230 232 +2
Partials 80 80
|
junqiu-lei
approved these changes
Jul 31, 2023
|
Please check on the CI failure |
|
Flaky test. Rerunning it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e1f41bb from #373