[Refactor] Strings utility methods to core library #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Signed-off-by: Heemin Kim <heemin@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
============================================
- Coverage 88.71% 88.56% -0.15%
+ Complexity 754 752 -2
============================================
Files 92 92
Lines 2711 2711
Branches 220 220
============================================
- Hits 2405 2401 -4
- Misses 228 230 +2
- Partials 78 80 +2
|
navneet1v
approved these changes
Aug 7, 2023
| @@ -12,7 +12,7 @@ | |||
| import java.util.List; | |||
|
|
|||
| import org.opensearch.client.node.NodeClient; | |||
| import org.opensearch.common.Strings; | |||
| import org.opensearch.core.common.Strings; | |||
There was a problem hiding this comment.
We don't need Strings class, unless it's used somewhere else in our plugin we need to remove this import
There was a problem hiding this comment.
It is used in this class.
martin-gaievski
approved these changes
Aug 7, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-379-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df00d455e393fec6c3106918903d2e27efb7bf90
# Push it to GitHub
git push --set-upstream origin backport/backport-379-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
heemin32
added a commit
to heemin32/geospatial
that referenced
this pull request
Aug 17, 2023
…t#379) Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32
added a commit
that referenced
this pull request
Aug 17, 2023
) * Switch from XContentType to MediaType to fix compilation errors (#366) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactor XContentFactory to MediaTypeRegistry (#374) Signed-off-by: Heemin Kim <heemin@amazon.com> * Refactor LifecycleComponent package path (#377) Signed-off-by: Heemin Kim <heemin@amazon.com> * [Refactor] Strings utility methods to core library (#379) Signed-off-by: Heemin Kim <heemin@amazon.com> * Fixed compilation errors after refactoring in core foundation classes (#380) Signed-off-by: Heemin Kim <heemin@amazon.com> --------- Signed-off-by: Heemin Kim <heemin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Refactor] Strings utility methods to core library
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.