Removing the security audit system index from getting deleted to fix the 2.10 integ tests failures #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navneet1v
added
backport 2.x
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
navneet1v
added
integ-test-failure
…the 2.10 integ tests failures Signed-off-by: Navneet Verma <navneev@amazon.com>
vibrantvarun
approved these changes
Sep 12, 2023
jmazanec15
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.10 #430 +/- ##
=========================================
Coverage 88.59% 88.59%
+ Complexity 753 752 -1
=========================================
Files 92 92
Lines 2717 2717
Branches 221 221
=========================================
Hits 2407 2407
Misses 230 230
Partials 80 80 |
junqiu-lei
approved these changes
Sep 12, 2023
naveentatikonda
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the security audit system index from getting deleted to fix the 2.10 integ tests failures
This is a temporary fix. Ideally we should delete the index from the test where it is getting created. Currently due to short time I cannot do that change as there are many reference of createIndex. Will fix this code starting from main branch and then backport to 2.x
Issues Resolved
#428
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.