Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default admin credentials in security test workflow #616

Merged

Conversation

ryanbogan
Copy link
Member

Description

Removes default admin credentials to align with security change for 2.12

Issues Resolved

#615

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@ryanbogan ryanbogan added skip-changelog v2.12.0 Issues targeting release v2.12.0 labels Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34aec65) 89.14% compared to head (f68f41f) 89.14%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #616   +/-   ##
=========================================
  Coverage     89.14%   89.14%           
- Complexity      767      768    +1     
=========================================
  Files            93       93           
  Lines          2746     2746           
  Branches        223      223           
=========================================
  Hits           2448     2448           
  Misses          219      219           
  Partials         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@martin-gaievski martin-gaievski added the backport 2.x Backport PR to 2.x branch label Jan 29, 2024
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@junqiu-lei junqiu-lei merged commit 7c214dc into opensearch-project:main Jan 30, 2024
36 of 37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2024
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
(cherry picked from commit 7c214dc)
junqiu-lei pushed a commit that referenced this pull request Jan 30, 2024
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
(cherry picked from commit 7c214dc)

Co-authored-by: Ryan Bogan <rbogan@amazon.com>
@ryanbogan ryanbogan deleted the remove_default_credentials branch January 30, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch skip-changelog v2.12.0 Issues targeting release v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants