Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Run cypress tests with security as a PR check #1203

Closed
cwperks opened this issue Nov 1, 2024 · 0 comments · Fixed by #1202
Closed

[FEATURE] Run cypress tests with security as a PR check #1203

cwperks opened this issue Nov 1, 2024 · 0 comments · Fixed by #1202
Labels
enhancement New feature or request untriaged

Comments

@cwperks
Copy link
Member

cwperks commented Nov 1, 2024

Is your feature request related to a problem?

During the 2.17.0 release and 2.18.0 release there were test failures observed when running the cypress tests in the FTR repo against a cluster with the security plugin installed and enabled. In order to catch issues early, its encouraged for plugin and dashboards-plugin repos to run integration/cypress tests with security.

In 2.17.0, the test failures stemmed from test cleanup issues where ISM Dashboards relied on the ability to delete the .opendistro-ism-config passing admin credentials. A fix in the FTR repo (PR) was done to use the admin certificate when making requests against that index.

In 2.18.0, there was a separate issue in this repo due to direct system index access introduced in this PR. A reviewer of that PR left a comment that direct system index access is discouraged and the contributor replied that a follow-through would happen in the subsequent release but it looks like the comment has remained unaddressed.

To catch these issues, this repo should run the cypress test contained in this repo both with security and without security.

@cwperks cwperks added enhancement New feature or request untriaged labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant