Fixes ISM cypress failures due to missing admin certificates #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
1 task
cwperks
approved these changes
Sep 11, 2024
derek-ho
approved these changes
Sep 11, 2024
|
Let's backport to main and 2.17 |
DarshitChanpura
commented
Sep 11, 2024
| "clientCertificates": [ | ||
| { | ||
| "url": "https://localhost:9200/.opendistro-ism*", | ||
| "ca": ["cypress/resources/root-ca.pem"], |
There was a problem hiding this comment.
these entries are needed else the tests would fail to start.
| @@ -68,7 +68,7 @@ Cypress.Commands.add('updateManagedIndexConfigStartTime', (index) => { | |||
| 'POST', | |||
| `${Cypress.env('openSearchUrl')}/${ | |||
| IM_CONFIG_INDEX.OPENDISTRO_ISM_CONFIG | |||
| }/_update_by_query`, | |||
| }/_update_by_query/`, | |||
There was a problem hiding this comment.
trailing slash is required for cypress to match client-certificates url correctly.
See here for more info.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit c0986d6)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit c0986d6)
cwperks
pushed a commit
that referenced
this pull request
Sep 11, 2024
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds admin certificates to requests interacting with system index.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.