Use admin cert and key when deleting system indices for cypress test cleanup #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleanup Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
Signed-off-by: Craig Perkins <cwperx@amazon.com>
vikasvb90
approved these changes
Sep 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…cleanup (#1174) * Use admin cert and key when deleting system indices for cypress test cleanup Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused imports Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit a343286) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…cleanup (#1174) * Use admin cert and key when deleting system indices for cypress test cleanup Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused imports Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit a343286) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90
pushed a commit
that referenced
this pull request
Sep 11, 2024
…cleanup (#1174) (#1176) * Use admin cert and key when deleting system indices for cypress test cleanup * Remove unused imports --------- (cherry picked from commit a343286) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90
pushed a commit
that referenced
this pull request
Sep 11, 2024
…cleanup (#1174) (#1175) * Use admin cert and key when deleting system indices for cypress test cleanup * Remove unused imports --------- (cherry picked from commit a343286) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
added a commit
to cwperks/index-management-dashboards-plugin
that referenced
this pull request
Oct 31, 2024
…ss test cleanup (opensearch-project#1174)" This reverts commit a343286. Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
added a commit
that referenced
this pull request
Nov 4, 2024
* Revert "Use admin cert and key when deleting system indices for cypress test cleanup (#1174)" This reverts commit a343286. Signed-off-by: Craig Perkins <cwperx@amazon.com> * Run Cypress Tests with security Signed-off-by: Craig Perkins <cwperx@amazon.com> * Create re-usable action Signed-off-by: Craig Perkins <cwperx@amazon.com> * Checkout branch Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add shell Signed-off-by: Craig Perkins <cwperx@amazon.com> * Use quotes Signed-off-by: Craig Perkins <cwperx@amazon.com> * Specify openSearchUrl Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove shell Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add security settings to dashboards config Signed-off-by: Craig Perkins <cwperx@amazon.com> * Change location Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update location Signed-off-by: Craig Perkins <cwperx@amazon.com> * Install security dashboards plugin Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix indentation error Signed-off-by: Craig Perkins <cwperx@amazon.com> * shell Signed-off-by: Craig Perkins <cwperx@amazon.com> * Run osd bootstrap Signed-off-by: Craig Perkins <cwperx@amazon.com> * Specify repository Signed-off-by: Craig Perkins <craig5008@gmail.com> * Reduce time and update creds Signed-off-by: Craig Perkins <craig5008@gmail.com> * Use GET /_tasks/<task_id> instead of direct access to system index Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix unit tests Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update snapshots Signed-off-by: Craig Perkins <cwperx@amazon.com> * Revert "Update snapshots" This reverts commit ce34314. Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add trailing slash Signed-off-by: Craig Perkins <craig5008@gmail.com> * Don't copy sec-dashboards-plugin if not running with security Signed-off-by: Craig Perkins <craig5008@gmail.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Craig Perkins <craig5008@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporary fix to use admin cert and key when performing test cleanup. The current test cleanup logic relies on deleting system indices and currently uses basic auth creds when performing the delete operation.
Ideally, any resources created in ISM can be cleaned up from a system index through an API.
i.e. If a test creates a policy, then at the end of the test call on delete policy API.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.