Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky #76

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Fix flaky #76

merged 3 commits into from
Sep 1, 2021

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Aug 31, 2021

Signed-off-by: bowenlan-amzn bowenlan23@gmail.com

Description

Flaky cypress bothered us for some time. This PR helps mitigate 2 kinds of flakiness:

  1. cypress original click() event not only performed just one native click event, refer to @AvivBenchorin's finding here. So instead of calling click() we should use trigger('click').
  2. If we call some backend API, then reload/visit page to expect some new info showing up, consider add a wait between them, sometimes backend API call hasn't been able to change the frontend view, we already rendered the frontend page again.

Issues Resolved

#30

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #76 (862fd09) into main (8f3f074) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   50.16%   50.16%           
=======================================
  Files         155      155           
  Lines        4288     4288           
  Branches      672      672           
=======================================
  Hits         2151     2151           
  Misses       1984     1984           
  Partials      153      153           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3f074...862fd09. Read the comment docs.

@bowenlan-amzn bowenlan-amzn merged commit 8b3c637 into opensearch-project:main Sep 1, 2021
@bowenlan-amzn bowenlan-amzn added the bug Something isn't working label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants