Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes policy details page #80

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Sep 1, 2021

  • Moves ISM templates out of the policy settings panel into it's own panel
  • Fixes the edit button always going to edit as JSON, now it shows a modal and lets user choose.
  • We were passing in error notification and trying to render as a channel id which crashes the page whenever there is an error notification, now we changed Channel ID -> Error Notification and have a link when it exists that opens up a JSON Modal w/ the error notification JSON
  • Fixes a bunch of typescript errors
  • Fixes states not actually being read-only on the policy details page by utilizing the passed in isReadOnly prop
  • Creates a JSONModal to reuse for policy JSON and error notification JSON

Signed-off-by: Drew Baugher 46505179+dbbaughe@users.noreply.github.com

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Screen Shot 2021-08-31 at 4 31 58 PM

Screen Shot 2021-08-31 at 4 32 03 PM

Screen Shot 2021-08-31 at 4 32 08 PM

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
@dbbaughe dbbaughe merged commit b284bd1 into opensearch-project:main Sep 1, 2021
@dbbaughe dbbaughe deleted the details-v2 branch September 1, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants