Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for notification channels #81

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Sep 1, 2021

Signed-off-by: Drew Baugher 46505179+dbbaughe@users.noreply.github.com

Description

Removes all backend routes/services relating to notification.
Removes all notification service and all usages of it.
Removes all usages of channels and any UI relating to channels.
The error notification is now just the JSON editor for what was the legacy error notifications.
Same for the notification action flyout.

Screen Shot 2021-08-31 at 7 05 53 PM

Screen Shot 2021-08-31 at 7 06 09 PM

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #81 (090e8b4) into main (b284bd1) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   50.03%   50.24%   +0.21%     
==========================================
  Files         156      154       -2     
  Lines        4297     4221      -76     
  Branches      678      664      -14     
==========================================
- Hits         2150     2121      -29     
+ Misses       1993     1950      -43     
+ Partials      154      150       -4     
Impacted Files Coverage Δ
...licy/components/UIActions/NotificationUIAction.tsx 4.34% <0.00%> (-4.28%) ⬇️
...ex-management-dashboards-plugin/utils/constants.ts 100.00% <0.00%> (ø)
...ement-dashboards-plugin/public/pages/Main/Main.tsx 10.00% <0.00%> (ø)
...public/pages/VisualCreatePolicy/utils/constants.ts 100.00% <0.00%> (ø)
...mponents/LegacyNotification/LegacyNotification.tsx 71.42% <0.00%> (ø)
...ards-plugin/public/services/NotificationService.ts
...onents/ChannelNotification/ChannelNotification.tsx
...-dashboards-plugin/public/index_management_app.tsx 7.69% <0.00%> (+0.54%) ⬆️
...ntainers/VisualCreatePolicy/VisualCreatePolicy.tsx 13.88% <0.00%> (+0.95%) ⬆️
...containers/ErrorNotification/ErrorNotification.tsx 100.00% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b284bd1...090e8b4. Read the comment docs.

Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dbbaughe dbbaughe merged commit b8aa974 into opensearch-project:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants