Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upadte admin credential in integration test #1076

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

Hailong-am
Copy link
Collaborator

Issue #, if available:
#1064

Description of changes:

  1. upadte admin credential in integration test

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6270b2c) 74.86% compared to head (30d1825) 74.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1076      +/-   ##
============================================
+ Coverage     74.86%   74.87%   +0.01%     
- Complexity     2808     2810       +2     
============================================
  Files           367      367              
  Lines         16518    16518              
  Branches       2362     2362              
============================================
+ Hits          12366    12368       +2     
+ Misses         2853     2847       -6     
- Partials       1299     1303       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenlan-amzn bowenlan-amzn merged commit 2a33173 into opensearch-project:main Jan 24, 2024
33 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1076-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2a33173a0e24b1dd6d78543d67591d6fd637df33
# Push it to GitHub
git push --set-upstream origin backport/backport-1076-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1076-to-2.x.

@bowenlan-amzn
Copy link
Member

@Hailong-am can you manual backport when you got time, thanks!

@Hailong-am
Copy link
Collaborator Author

git worktree remove ../.worktrees/index-management/backport-2.x

sure, here is the PR #1084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants