Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI check for integ-test-with-security to run all integ tests with security #1243

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 10, 2024

Description

This updates another instance where the client is used instead of adminClient which results in an integ test failure when the security plugin is installed.

Mitigates this test failure observed in ShrinkActionIT

REPRODUCE WITH: ./gradlew ':integTest' --tests "org.opensearch.indexmanagement.indexstatemanagement.action.ShrinkActionIT.test allocation block picks correct node with exclude node" -Dtests.seed=171CE8075C46FB4E -Dtests.security.manager=false -Dtests.locale=ru -Dtests.timezone=Etc/GMT -Druntime.java=21

2> org.opensearch.client.ResponseException: method [PUT], host [https://localhost:9200/], URI [.opendistro-ism-config/_settings], status line [HTTP/1.1 403 Forbidden]

{"error":{"root_cause":[{"type":"security_exception","reason":"no permissions for [] and User [name=admin, backend_roles=[admin], requestedTenant=null]"}],"type":"security_exception","reason":"no permissions for [] and User [name=admin, backend_roles=[admin], requestedTenant=null]"},"status":403}

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@vikasvb90 vikasvb90 merged commit 395317d into opensearch-project:main Sep 11, 2024
28 of 29 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1243-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 395317dcc40762fc05b4320885c2ea27be572324
# Push it to GitHub
git push --set-upstream origin backport/backport-1243-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1243-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.17
# Create a new branch
git switch --create backport/backport-1243-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 395317dcc40762fc05b4320885c2ea27be572324
# Push it to GitHub
git push --set-upstream origin backport/backport-1243-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-1243-to-2.17.

gaiksaya pushed a commit that referenced this pull request Sep 11, 2024
…ith security (#1243)

* Run all integ tests with security

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 395317d)
@gaiksaya
Copy link
Member

gaiksaya commented Sep 11, 2024

Created a backport PR for 2.17 #1244
Closed due to too much diff in changed files. Will let maintainers take care.

Someone please take care of failed backports.
@tandonks @vikasvb90

gaiksaya pushed a commit that referenced this pull request Sep 11, 2024
…ith security (#1243)

* Run all integ tests with security

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 395317d)
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
cwperks added a commit to cwperks/index-management that referenced this pull request Sep 11, 2024
…ith security (opensearch-project#1243)

* Run all integ tests with security

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Use adminClient when deleting ISM index in RestStopRollupActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update RolloverActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix RestStopSnapshotManagementIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix RestChangePolicyActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix RestExplainTransformActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Make sure read from system index also uses adminClient

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 395317d)
cwperks added a commit to cwperks/index-management that referenced this pull request Sep 11, 2024
…ith security (opensearch-project#1243)

* Run all integ tests with security

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Use adminClient when deleting ISM index in RestStopRollupActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update RolloverActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix RestStopSnapshotManagementIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix RestChangePolicyActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix RestExplainTransformActionIT

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix more tests

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Make sure read from system index also uses adminClient

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 395317d)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants