Removes checked in js zip #403
Conversation
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 1.x #403 +/- ##
============================================
+ Coverage 75.60% 75.64% +0.04%
- Complexity 1997 2015 +18
============================================
Files 253 253
Lines 11466 11489 +23
Branches 1815 1819 +4
============================================
+ Hits 8669 8691 +22
- Misses 1765 1767 +2
+ Partials 1032 1031 -1
Continue to review full report at Codecov.
|
|
Whitesource failing with
|
Signed-off-by: Clay Downs <downsrob@amazon.com>
|
@prudhvigodithi It addresses the mentioned issue #402 |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-403-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e9075dd2ebfa3e3f916614d132fb101c1ad0b2a1
# Push it to GitHub
git push --set-upstream origin backport/backport-403-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3Then, create a pull request where the |
|
why do it this way around? as the infrastructure is now in place to publish everything to maven and you already have a snapshot maven repo located here you could use that: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/ @prudhvigodithi: it seems that the snapshots of plugin ZIPs are not (yet) published there. if they would be this would allow you to just use them as normal maven dependencies here in the gradle build w/o having to manually construct any URLs and downloading them manually. |
Hey @rursprung snapshots can be fetched from nexus maven repo Quick test: |
|
Just to add the PluginZips are out in maven starting 2.1.0, 1.x versions have to be backfilled. |
* Removes job scheduler static dependency Signed-off-by: Clay Downs <downsrob@amazon.com> * Removes print statement to fix dependency order Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds missed code Signed-off-by: Clay Downs <downsrob@amazon.com>
* Removes job scheduler static dependency Signed-off-by: Clay Downs <downsrob@amazon.com> * Removes print statement to fix dependency order Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds missed code Signed-off-by: Clay Downs <downsrob@amazon.com>
* Removes checked in js zip (#403) * Removes job scheduler static dependency Signed-off-by: Clay Downs <downsrob@amazon.com> * Removes print statement to fix dependency order Signed-off-by: Clay Downs <downsrob@amazon.com> * Adds missed code Signed-off-by: Clay Downs <downsrob@amazon.com> * Removes checked in zip Signed-off-by: Clay Downs <89109232+downsrob@users.noreply.github.com> Signed-off-by: Clay Downs <downsrob@amazon.com>
Issue #, if available:
#402
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.