Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3]Transform maxclauses fix (#477) (#482) #489

Merged

Conversation

Angie-Zhang
Copy link
Contributor

  • transform maxClauses fix

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • added bucket log to track processed buckets

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • various renames/changes

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • fixed detekt issues

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • added comments to test

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • removed debug logging

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • empty commit to trigger checks

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

  • reverted pagesProcessed change; fixed few ITs

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com
(cherry picked from commit 7475cfd)

Co-authored-by: Petar Dzepina petar.dzepina@gmail.com
(cherry picked from commit b39bd64)

Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…#482)

* transform maxClauses fix

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added bucket log to track processed buckets

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* various renames/changes

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* fixed detekt issues

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* added comments to test

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* removed debug logging

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* empty commit to trigger checks

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reduced pageSize to 1 in few ITs to avoid flaky tests; fixed bug where pagesProcessed was calculated incorrectly

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* reverted pagesProcessed change; fixed few ITs

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 7475cfd)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit b39bd64)
@Angie-Zhang Angie-Zhang marked this pull request as ready for review September 1, 2022 22:47
@Angie-Zhang Angie-Zhang requested a review from a team September 1, 2022 22:47
@Angie-Zhang Angie-Zhang changed the title Transform maxclauses fix (#477) (#482) [Backport 1.3]Transform maxclauses fix (#477) (#482) Sep 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #489 (ba34687) into 1.3 (b47bcb1) will decrease coverage by 0.03%.
The diff coverage is 93.54%.

❗ Current head ba34687 differs from pull request most recent head 3ff2153. Consider uploading reports for the commit 3ff2153 to get more accurate results

@@             Coverage Diff              @@
##                1.3     #489      +/-   ##
============================================
- Coverage     75.72%   75.69%   -0.04%     
- Complexity     2010     2023      +13     
============================================
  Files           253      254       +1     
  Lines         11475    11521      +46     
  Branches       1816     1823       +7     
============================================
+ Hits           8690     8721      +31     
- Misses         1759     1768       +9     
- Partials       1026     1032       +6     
Impacted Files Coverage Δ
.../org/opensearch/indexmanagement/util/IndexUtils.kt 74.66% <ø> (ø)
...anagement/transform/TransformProcessedBucketLog.kt 86.66% <86.66%> (ø)
...ndexmanagement/transform/TransformSearchService.kt 66.28% <87.50%> (+0.60%) ⬆️
...earch/indexmanagement/transform/TransformRunner.kt 87.27% <97.43%> (+0.84%) ⬆️
...statemanagement/model/destination/CustomWebhook.kt 65.21% <0.00%> (-27.54%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 84.90% <0.00%> (+0.47%) ⬆️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 66.56% <0.00%> (+0.59%) ⬆️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 78.03% <0.00%> (+1.40%) ⬆️
...nt/indexstatemanagement/model/destination/Slack.kt 54.54% <0.00%> (+13.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

khushbr
khushbr previously approved these changes Sep 2, 2022
@khushbr
Copy link
Contributor

khushbr commented Sep 2, 2022

Whitesource Security Check is failing, can you fix it ? https://github.com/opensearch-project/index-management/pull/489/checks?check_run_id=8146400738

@khushbr khushbr self-requested a review September 2, 2022 02:03
@Angie-Zhang Angie-Zhang closed this Sep 6, 2022
@Angie-Zhang Angie-Zhang deleted the backport/backport-482-to-1.3 branch September 6, 2022 23:31
@Angie-Zhang Angie-Zhang restored the backport/backport-482-to-1.3 branch September 6, 2022 23:33
@Angie-Zhang Angie-Zhang reopened this Sep 6, 2022
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
@bowenlan-amzn bowenlan-amzn merged commit 73161b5 into opensearch-project:1.3 Oct 4, 2022
@Angie-Zhang Angie-Zhang deleted the backport/backport-482-to-1.3 branch October 13, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants