Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Set in org.opensearch.common.collect with java.util references #717

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Hailong-am
Copy link
Collaborator

Issue #, if available:
#716

Description of changes:
Replace Set in org.opensearch.common.collect with java.util references

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…a.util references

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am requested a review from a team March 22, 2023 06:19
Copy link
Contributor

@gaobinlong gaobinlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #717 (4298db2) into main (c751746) will increase coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #717      +/-   ##
============================================
+ Coverage     75.87%   75.90%   +0.03%     
- Complexity     2654     2655       +1     
============================================
  Files           333      333              
  Lines         15400    15400              
  Branches       2272     2272              
============================================
+ Hits          11684    11690       +6     
+ Misses         2397     2390       -7     
- Partials       1319     1320       +1     

see 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Hailong-am Hailong-am merged commit 8fe17c7 into opensearch-project:main Mar 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 24, 2023
…a.util references (#717)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 8fe17c7)
Hailong-am added a commit that referenced this pull request Mar 24, 2023
…a.util references (#717) (#719)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 8fe17c7)

Co-authored-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am deleted the issue/716 branch March 24, 2023 06:40
ronnaksaxena pushed a commit to ronnaksaxena/index-management that referenced this pull request Jul 19, 2023
…a.util references (opensearch-project#717) (opensearch-project#719)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 8fe17c7)

Co-authored-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Ronnak Saxena <ronsax@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants