Adding XContentType.JSON to Strings.toString() #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
saratvemulapalli
approved these changes
Jan 27, 2023
dbwiddis
reviewed
Jan 27, 2023
dbwiddis
approved these changes
Jan 27, 2023
|
Approved, not merging because I don't understand the test failures. |
|
@dbwiddis Test failures are due to stale OpenSearch 3.0.0 artifacts. Once the latest OS 3.0.0 build passes, I'll re-run the failed checks and these should pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Palis jpalis@amazon.com
Description
Adds XContentType.JSON parameter to
Strings.toStringsdue to changes toorg.opensearch.common.Strings.opensearch-project/OpenSearch#6009
Issues Resolved
#308
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.