-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plugin Code Coverage #616
Conversation
FYI, I allowed the tests to run few times since yesterday and I get the following error.
Let me add a Codecov token and update the test workflow to use the token for uploading the test report. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
============================================
+ Coverage 29.17% 37.37% +8.20%
- Complexity 98 133 +35
============================================
Files 22 22
Lines 1186 1188 +2
Branches 109 109
============================================
+ Hits 346 444 +98
+ Misses 819 707 -112
- Partials 21 37 +16 ☔ View full report in Codecov by Sentry. |
Works now https://app.codecov.io/gh/opensearch-project/job-scheduler/pull/616 and I see the percentage is now 37.27% (from 29.17%). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a first pass. Thank you for adding missing test! This change looks good to me, just left some minor comments.
src/test/java/org/opensearch/jobscheduler/JobSchedulerPluginTests.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/jobscheduler/JobSchedulerPlugin.java
Outdated
Show resolved
Hide resolved
Thanks @cwperks for reviewing the PR, initially I have to update the access modifiers to make sure those variables/methods are accessible for testing, I have reverted back and replaced to get the getters, can you review again? |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
84746aa
into
opensearch-project:main
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 84746aa) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 84746aa) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This is the 1st PR as part of this issue to improve the repo code coverage gradually.
Issues Resolved
Part of #612
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.