-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Support #157
Comments
@vamshin We have started the work on adding support for Windows distribution and need your inputs on the timeline to support KNN on Windows. |
Hey @vamshin, do we have any updates here? |
Hi @bbarani @peterzhuamazon, since we are tracking Windows effort with milestones, is there a specific milestone we would like to map the KNN effort with, to ensure we have these artifacts in time for the 2.4 release? That should help @vamshin and team to plan accordingly. cc @elfisher |
Current issues:
|
New issues, the lib files provided by the knn team is invalid:
|
New issues: How to make sure the plugin/libs folder present in java.library.path:
Probably will try to append the path like linux version through the OS startup batch script. |
I am able to add the path to java.library.path On windows as long as you expose the path into Path variable it will expose to the java.library.path We can add a batch file through cmd commands to dynamically update the Path variable during startup |
We are able to successfully install knn on 2.3.0 snapshot windows zip and complete the KNN integTest run. Notes:
|
|
@naveentatikonda Could you help comment on what is the issue with BWC test challenges on KNN for windows support? cc: @setiah |
@peterzhuamazon We might need to make few changes to the BWC framework to make it compatible with windows. For example url of the tar file. To test this and make those changes we need an artifact of any BWC version with k-NN plugin bundled in that artifact. Also, as per our previous conversation I know we need to push our windows changes to 2.x branch for you to include k-NN plugin into that artifact. But, for now will you be able to pick those changes from any feature branch as we are still trying to make our script more organic without any work arounds? |
Have some discussion with @naveentatikonda and he would provide two branches for 2.3.0 and 2.2.1 respectively. I will use those branches to build bundles on my fork. Then he can try to implement the bwc test. Thanks. |
@peterzhuamazon windows_support_v4 this feature branch on my fork points to OS version 2.3.0 and ws_os_version_2.2.1 points to OS version 2.2.1. Please let me know if you need anything else, Thanks! |
@peterzhuamazon do we have any update on this ? Also, just want to remind you about the changes that you want to make for the jenkins build script |
@naveentatikonda sorry for the late reply I would have some time tomorrow to get a bundle. Thanks. |
Working on building 2.3.0 with windows_support_v4 branch now and also editing the build script. |
Coming from opensearch-project/opensearch-plugins#95, add Windows support.
The text was updated successfully, but these errors were encountered: