Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Add Windows Support #95

Open
25 of 28 tasks
Tracked by #33 ...
dblock opened this issue Oct 27, 2021 · 9 comments
Open
25 of 28 tasks
Tracked by #33 ...

[META] Add Windows Support #95

dblock opened this issue Oct 27, 2021 · 9 comments
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New feature or request Meta windows

Comments

@dblock
Copy link
Member

dblock commented Oct 27, 2021

Is your feature request related to a problem?

Coming from opensearch-project/opensearch-build#33. In order to release a Windows x64 distribution each plugin needs to work on Windows and include tools that are windows-specific as replacements for any bash scripts.

What solution would you like?

Every component has passing CI on Windows (windows-latest on GHA), including unit, integration and bcw tests, and has Windows-specific documentation, if needed.

Example PR: opensearch-project/index-management#210

@dblock dblock added enhancement New feature or request Meta labels Oct 27, 2021
@dblock dblock added the windows label Oct 27, 2021
@peterzhuamazon peterzhuamazon changed the title Add Windows Support [META] Add Windows Support Jul 8, 2022
@dblock dblock added the v2.4.0 'Issues and PRs related to version v2.4.0' label Sep 29, 2022
@dblock
Copy link
Member Author

dblock commented Sep 29, 2022

OpenSearch Windows CI: opensearch-project/OpenSearch#1448
OpenSearch Dashboards Windows CI: opensearch-project/OpenSearch-Dashboards#2451

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Sep 29, 2022

Add geospatial, dashboards-maps, common-utils:

opensearch-project/geospatial#158
opensearch-project/dashboards-maps#55
opensearch-project/common-utils#256

@derek-ho
Copy link

derek-ho commented Oct 12, 2022

Hi all, I am trying to enable this for a few plugins (observability, sql, dashboards-reports, dashboards-visualizations), and am wondering if it makes sense to disable backward compatibility tests since this is the first release on windows/macos.
Also seeing several errors like the following for windows/macos CI:
Could not HEAD 'https://artifacts.opensearch.org/releases/core/opensearch/1.1.0/opensearch-min-1.1.0-windows-x64.zip'. Received status code 403 from server: Forbidden. Is this a known infra issue/will be resolved at some point? Thanks

@peterzhuamazon
Copy link
Member

Hi all, I am trying to enable this for a few plugins (observability, sql, dashboards-reports, dashboards-visualizations), and am wondering if it makes sense to disable backward compatibility tests since this is the first release on windows/macos. Also seeing several errors like the following for windows/macos CI: Could not HEAD 'https://artifacts.opensearch.org/releases/core/opensearch/1.1.0/opensearch-min-1.1.0-windows-x64.zip'. Received status code 403 from server: Forbidden. Is this a known infra issue/will be resolved at some point? Thanks

There is no 1.1.0 windows for sure because we havent release windows yet......
@CEHENKLE @bbarani wonder if we want to enable this once we have 1.x windows release later?

Thanks.

@dblock
Copy link
Member Author

dblock commented Oct 19, 2022

I think we should manually publish an 2.3.0 Windows build that I know we were able to produce, to support bcw. If we ship 2.4.0 with Windows support and 2.5.0 fails to upgrade because of something in 2.4.0 it will be a lot more difficult to fix.

@bbarani
Copy link
Member

bbarani commented Oct 19, 2022

@peterzhuamazon Can we publish the Windows -min artifacts to artifacts.opensearch.org as well to unblock opensearch-project/sql#928?

@peterzhuamazon
Copy link
Member

We already have 2.4.0 min in snapshots on artifacts, not 2.3.0 tho.

@peterzhuamazon
Copy link
Member

My point being that are pointing to the wrong location, should be snapshots not releases or release-candidates anymore.

@dblock
Copy link
Member Author

dblock commented Nov 3, 2022

We found that a number of child issues were closed with only partial working CI (unit tests, but not integration tests). Those issues have been reopened and I updated the description here to reflect that we want 100% parity in tests across all supported platforms, linux and windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign Parent issues of OpenSearch release campaigns. enhancement New feature or request Meta windows
Projects
None yet
Development

No branches or pull requests

4 participants