Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support #361

Closed
2 tasks
Tracked by #95
peterzhuamazon opened this issue Jul 8, 2022 · 7 comments
Closed
2 tasks
Tracked by #95

Add Windows Support #361

peterzhuamazon opened this issue Jul 8, 2022 · 7 comments
Labels

Comments

@peterzhuamazon
Copy link
Member

Coming from opensearch-project/opensearch-plugins#95, add Windows support.

  • Passing CI on Windows
  • Documentation
@bbarani
Copy link
Member

bbarani commented Oct 26, 2022

@ylwu-amzn @sean-zheng-amazon Can you please update the current status?

@bbarani bbarani added the v2.4.0 label Oct 26, 2022
@ylwu-amzn
Copy link
Collaborator

@bbarani , thanks for reminding, looking this now.
Can you share some action items we should do to support windows? Or maybe some example ?

@ylwu-amzn
Copy link
Collaborator

Never mind, I found SQL team has done that. Will refer to SQL plugin

@ylwu-amzn
Copy link
Collaborator

#504

@ylwu-amzn ylwu-amzn reopened this Nov 3, 2022
@ylwu-amzn
Copy link
Collaborator

CustomModelITTests#testCustomModelWorkflow will fail to clean up local file cache. Test code run successfully, but test framework failed to cleanup temp local files.

at __randomizedtesting.SeedInfo.seed([D97C315DD114CE48]:0)
	at org.apache.lucene.util.IOUtils.rm(IOUtils.java:341)
	at org.apache.lucene.tests.util.TestRuleTemporaryFilesCleanup.afterAlways(TestRuleTemporaryFilesCleanup.java:209)
	at com.carrotsearch.randomizedtesting.rules.TestRuleAdapter$1.afterAlways(TestRuleAdapter.java:31)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:833)

@ylwu-amzn
Copy link
Collaborator

I reopen this issue as we should support " 100% parity in tests across all supported platforms, linux and windows.", refer to opensearch-project/opensearch-plugins#95 (comment)

@peterzhuamazon
Copy link
Member Author

Hi, just want to make sure this issue is closed, if all the tasks are completed.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants