test windows build

[ylwu-amzn]

Signed-off-by: Yaliang Wu ylwu@amazon.com

Description

Found several issues when run on windows

1. CustomModelITTests#testCustomModelWorkflow will fail to clean up local file cache. Test code run successfully, but test framework failed to cleanup temp local files.

at __randomizedtesting.SeedInfo.seed([D97C315DD114CE48]:0)
	at org.apache.lucene.util.IOUtils.rm(IOUtils.java:341)
	at org.apache.lucene.tests.util.TestRuleTemporaryFilesCleanup.afterAlways(TestRuleTemporaryFilesCleanup.java:209)
	at com.carrotsearch.randomizedtesting.rules.TestRuleAdapter$1.afterAlways(TestRuleAdapter.java:31)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:833)

2. RestMLCustomModelActionIT#testCustomModelWorkflow can run successfully on test windows EC2 by running ./gradlew.bat build, but it's flaky on GIthub CI runner node. So I have to ignore this.

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #504 (441420c) into 2.x (8c8e2a5) will decrease coverage by 11.29%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x     #504       +/-   ##
=============================================
- Coverage     78.17%   66.88%   -11.30%     
+ Complexity      864      769       -95     
=============================================
  Files            86       86               
  Lines          3267     3267               
  Branches        309      309               
=============================================
- Hits           2554     2185      -369     
- Misses          573      975      +402     
+ Partials        140      107       -33     

Flag	Coverage Δ
ml-commons	66.88% <ø> (-11.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...h/ml/action/unload/TransportUnloadModelAction.java	17.77% <0.00%> (-71.12%)	⬇️
.../ml/action/syncup/TransportSyncUpOnNodeAction.java	16.92% <0.00%> (-60.00%)	⬇️
...arch/ml/action/forward/TransportForwardAction.java	19.17% <0.00%> (-52.06%)	⬇️
...n/java/org/opensearch/ml/model/MLModelManager.java	17.73% <0.00%> (-45.64%)	⬇️
...ml/action/load/TransportLoadModelOnNodeAction.java	18.88% <0.00%> (-45.56%)	⬇️
...h/ml/action/upload/TransportUploadModelAction.java	25.00% <0.00%> (-41.08%)	⬇️
...java/org/opensearch/ml/profile/MLModelProfile.java	53.84% <0.00%> (-30.77%)	⬇️
...ch/ml/action/profile/MLProfileTransportAction.java	81.25% <0.00%> (-12.50%)	⬇️
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java	43.93% <0.00%> (-9.10%)	⬇️
...va/org/opensearch/ml/task/MLExecuteTaskRunner.java	75.86% <0.00%> (-6.90%)	⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ylwu-amzn]

No clear idea to solve the fail to clean up local temp file error. Merge this PR to unblock windows build, create an issue to track it #505

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-504-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ebd2e6fad884829781342a79157a9eba9ca5a47
# Push it to GitHub
git push --set-upstream origin backport/backport-504-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-504-to-1.3.