Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support #33

Closed
2 tasks
Tracked by #95
dblock opened this issue Oct 27, 2021 · 8 comments
Closed
2 tasks
Tracked by #95

Add Windows Support #33

dblock opened this issue Oct 27, 2021 · 8 comments
Labels

Comments

@dblock
Copy link
Member

dblock commented Oct 27, 2021

Coming from opensearch-project/opensearch-plugins#95, add Windows support.

  • Passing CI on Windows
  • Documentation
@anirudha
Copy link
Collaborator

not applicable

@dblock
Copy link
Member Author

dblock commented Oct 30, 2021

Adding Windows CI will ensure that the plugin actually works on Windows, we can't assume that it works because it's theoretically portable.

@dblock
Copy link
Member Author

dblock commented Nov 3, 2022

I don't believe integration tests are running, and integration tests are very much part of CI. Reopening. Please close when this and any other gaps between Linux/Windows CI/CD are covered.

@dblock dblock reopened this Nov 3, 2022
@peterzhuamazon
Copy link
Member

Hi, just want to make sure this issue is closed, if all the tasks are completed.

Thanks.

@CEHENKLE
Copy link
Member

@anirudha Can you please address @dblock's questions?

@CEHENKLE
Copy link
Member

@anirudha Poke!

@CEHENKLE
Copy link
Member

CEHENKLE commented Feb 2, 2023

@anirudha Can you address @dblock's question?

@rupal-bq
Copy link
Contributor

rupal-bq commented Feb 9, 2023

Closing this as there are no gaps between Linux/Windows CI/CD.

@rupal-bq rupal-bq closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants