Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for windows and macos #117

Merged
merged 9 commits into from
Oct 12, 2022

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Oct 11, 2022

Signed-off-by: Derek Ho dxho@amazon.com

Description

Enable windows and macos builds

Issues Resolved

#33, #34

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho requested a review from a team as a code owner October 11, 2022 15:22
@derek-ho
Copy link
Collaborator Author

Addresses #33, #34

@derek-ho derek-ho marked this pull request as draft October 11, 2022 15:27
Signed-off-by: Derek Ho <dxho@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #117 (b8cd715) into main (8a9008d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho marked this pull request as ready for review October 11, 2022 18:30
Signed-off-by: Derek Ho <dxho@amazon.com>
@joshuali925 joshuali925 merged commit 10eed4b into opensearch-project:main Oct 12, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 10eed4b)
joshuali925 pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 10eed4b)

Co-authored-by: Derek Ho <derek01778@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 6, 2022
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 10eed4b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 6, 2022
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 10eed4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants