Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running tests against Windows artifact #321

Open
tianleh opened this issue Oct 11, 2022 · 7 comments
Open

Support running tests against Windows artifact #321

tianleh opened this issue Oct 11, 2022 · 7 comments

Comments

@tianleh
Copy link
Member

tianleh commented Oct 11, 2022

Inspired by opensearch-project/opensearch-plugins#95 , create an issue to support running tests against Windows artifact.

@tianleh
Copy link
Member Author

tianleh commented Oct 12, 2022

cc @peterzhuamazon

@tianleh
Copy link
Member Author

tianleh commented Oct 12, 2022

synced up with @peterzhuamazon The execution of the artifact and the test could all happen in the windows server. There won't be Docker for Windows. Peter will check into the Cypress support in Windows next week.

@seraphjiang
Copy link
Member

seraphjiang commented Oct 12, 2022

Ideally, functional test should has dependencies on Browser, but not OS.

what does it mean

browser test should run browser test on test agent only required for test
browser test should not run browser test on test server which hosts opensearch or opensearch dashboards

in order to support that, we need to build test infrastructure which could launch test environment only required to run browser test.

unless we are going to certify cross browser and cross OS support (which is only important, but different priority), the test infra should not be blocked by support new OS(hosting environment)

@tianleh
Copy link
Member Author

tianleh commented Oct 12, 2022

Ideally, functional test should has dependencies on Browser, but not OS.

I was thinking about running Windows artifact on Windows and then exposing the endpoint. Then the tests can still run in a Linux env. However, this may require a remote endpoint.

Running the artifact and the tests together in the Windows env is more convenient to avoid the remote endpoint. The cost is that we need to have Cypress installed in Windows.

@peterzhuamazon
Copy link
Member

Verified we can directly install cypress on windows through npm.

$ ./Cypress.exe --version

9.5.4

$ file Cypress.exe
Cypress.exe: PE32+ executable (GUI) x86-64, for MS Windows

The installed version, unlike arm64, is native.

@peterzhuamazon
Copy link
Member

Next step:

  • Adding cypress as part of the windows ami
  • Run some existing test on windows with cypress.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Nov 3, 2022

More development and issues in here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants