Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test and build workflow for mac and windows #210

Merged
merged 14 commits into from
Dec 8, 2021

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented Dec 3, 2021

Issue #, if available:
#173 #172
Description of changes:

  • Adds windows and mac build tasks to the test and build workflow to run as part of github CI. As there currently are no min distributions for mac or windows, plugins are blocked on running integration tests on mac or windows machines. While waiting for the min distribution, integration tests are disabled, but unit tests and build tasks are run.
  • Artifacts are uploaded for each build. Though the artifacts differ very little, with just different line ending for windows, and different manifests documenting the build OS, they may be useful for debugging a build failure on the mac or windows distribution.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbbaughe
Copy link
Contributor

dbbaughe commented Dec 3, 2021

@downsrob Do we also need to add windows/mac to the multi node workflow?

@downsrob
Copy link
Contributor Author

downsrob commented Dec 3, 2021

@downsrob Do we also need to add windows/mac to the multi node workflow?

@dbbaughe We may want to at a later stage, but the multi node workflow only runs the integTest gradle action, which is also the only action which doesn't work because of missing the min distribution. So there is no point adding it in now I think

Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #210 (97cfabc) into main (f1af390) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #210      +/-   ##
============================================
+ Coverage     75.95%   76.11%   +0.15%     
- Complexity     1935     1949      +14     
============================================
  Files           260      260              
  Lines         11094    11122      +28     
  Branches       1746     1753       +7     
============================================
+ Hits           8427     8466      +39     
+ Misses         1709     1700       -9     
+ Partials        958      956       -2     
Impacted Files Coverage Δ
...nt/indexstatemanagement/model/destination/Slack.kt 40.90% <0.00%> (-13.64%) ⬇️
...ort/action/getpolicy/TransportGetPoliciesAction.kt 75.00% <0.00%> (-4.55%) ⬇️
...transport/action/explain/TransportExplainAction.kt 69.36% <0.00%> (-4.05%) ⬇️
...gedindex/TransportRetryFailedManagedIndexAction.kt 61.80% <0.00%> (-2.78%) ⬇️
...nt/rollup/action/stop/TransportStopRollupAction.kt 69.51% <0.00%> (-1.22%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 65.06% <0.00%> (-1.21%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 86.00% <0.00%> (-1.00%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 71.08% <0.00%> (-0.70%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 67.60% <0.00%> (-0.09%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 84.43% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1af390...97cfabc. Read the comment docs.

@dbbaughe
Copy link
Contributor

dbbaughe commented Dec 7, 2021

@dblock

As we add these matrix of tests (OS', JVMs, BWC, Perf, Plugin specifc, etc.) we're going to start seeing plugins running a huge amount of tests on the runners for each repository.

Are we worried at all about GitHub runner limits? Are there any limits for our org for how many can be run in parallel at the same time? Definitely don't want to start seeing these get queue'd up and take hours to finish for simple PRs.

Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
dbbaughe
dbbaughe previously approved these changes Dec 8, 2021
thalurur
thalurur previously approved these changes Dec 8, 2021
Signed-off-by: Robert Downs <downsrob@amazon.com>
@downsrob downsrob dismissed stale reviews from thalurur and dbbaughe via c7d4bb5 December 8, 2021 18:07
@downsrob downsrob requested a review from a team December 8, 2021 18:07
@downsrob downsrob merged commit 1fec52e into opensearch-project:main Dec 8, 2021
@downsrob downsrob deleted the adds-windows branch December 8, 2021 18:52
downsrob added a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
)

* Adds test and build workflow for mac and windows

Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob added a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
)

* Adds test and build workflow for mac and windows

Signed-off-by: Robert Downs <downsrob@amazon.com>
downsrob added a commit that referenced this pull request Mar 9, 2022
* Adds test and build workflow for mac and windows

Signed-off-by: Robert Downs <downsrob@amazon.com>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
)

* Adds test and build workflow for mac and windows

Signed-off-by: Robert Downs <downsrob@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants