-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds test and build workflow for mac and windows #210
Conversation
@downsrob Do we also need to add windows/mac to the multi node workflow? |
@dbbaughe We may want to at a later stage, but the multi node workflow only runs the integTest gradle action, which is also the only action which doesn't work because of missing the min distribution. So there is no point adding it in now I think |
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
458518d
to
4e26bd0
Compare
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
============================================
+ Coverage 75.95% 76.11% +0.15%
- Complexity 1935 1949 +14
============================================
Files 260 260
Lines 11094 11122 +28
Branches 1746 1753 +7
============================================
+ Hits 8427 8466 +39
+ Misses 1709 1700 -9
+ Partials 958 956 -2
Continue to review full report at Codecov.
|
As we add these matrix of tests (OS', JVMs, BWC, Perf, Plugin specifc, etc.) we're going to start seeing plugins running a huge amount of tests on the runners for each repository. Are we worried at all about GitHub runner limits? Are there any limits for our org for how many can be run in parallel at the same time? Definitely don't want to start seeing these get queue'd up and take hours to finish for simple PRs. |
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: Robert Downs <downsrob@amazon.com>
* Adds test and build workflow for mac and windows Signed-off-by: Robert Downs <downsrob@amazon.com>
Issue #, if available:
#173 #172
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.