Add short circuit if no live docs are in segments #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
requested review from
heemin32,
navneet1v,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
VijayanB
force-pushed
the
return-live-docs
branch
2 times, most recently
from
90d1f44
to
f06dc38
Compare
jmazanec15
reviewed
Sep 6, 2024
| // Count the docIds | ||
| int totalLiveDocs = getLiveDocs(vectorValuesRetriever.apply(vectorDataType, fieldInfo, VectorProcessingContext)); | ||
| if (quantizationParams != null && totalLiveDocs > 0) { | ||
| if (totalLiveDocs == 0) { | ||
| log.debug("No live docs for field " + fieldInfo.name); |
There was a problem hiding this comment.
Just to confirm - this wont lead to an issue on search if an empty file is expected?
There was a problem hiding this comment.
@jmazanec15 Can you give more context when do we expect empty file? I see this is already added inside index method
There was a problem hiding this comment.
For search and warmup, we should make sure that we arent reading this file if the size is empy
There was a problem hiding this comment.
Discussed offline and confirmed that if file is empty, we are not reading the file since we check whether file exists or not before reading it.
jmazanec15
approved these changes
Sep 11, 2024
Vikasht34
approved these changes
Sep 12, 2024
naveentatikonda
approved these changes
Sep 12, 2024
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
return-live-docs
branch
from
f06dc38
to
0bf2e77
Compare
|
CI failure is not related to this PR. It is failing since we are in the midst of release. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Add short circuit if no live docs are in segments Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 7aedefd)
VijayanB
added a commit
that referenced
this pull request
Sep 13, 2024
* Add short circuit if no live docs are in segments Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 7aedefd) Co-authored-by: Vijayan Balasubramanian <balasvij@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.