Remove hardcoding of version in knn CI #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
This was referenced Mar 28, 2022
martin-gaievski
approved these changes
Mar 28, 2022
naveentatikonda
approved these changes
Mar 28, 2022
VijayanB
approved these changes
Mar 28, 2022
dreamer-89
approved these changes
Mar 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
=========================================
Coverage 83.81% 83.81%
Complexity 900 900
=========================================
Files 130 130
Lines 3844 3844
Branches 360 360
=========================================
Hits 3222 3222
Misses 459 459
Partials 163 163 Continue to review full report at Codecov.
|
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Remove hardcoding of version in knn CI.
The value should be taken from build.gradle.
Thanks.
Issues Resolved
Part of opensearch-project/opensearch-build#1632
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.