Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for version increment automation #436

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Jul 10, 2022

Signed-off-by: pgodithi pgodithi@amazon.com

Description

This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: prudhvigodithi#1

Issues Resolved

Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #433

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi requested a review from a team July 10, 2022 13:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #436 (5b9e5eb) into 1.x (b83c88f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x     #436      +/-   ##
============================================
- Coverage     83.43%   83.42%   -0.01%     
  Complexity      900      900              
============================================
  Files           127      127              
  Lines          3864     3862       -2     
  Branches        367      367              
============================================
- Hits           3224     3222       -2     
  Misses          476      476              
  Partials        164      164              
Impacted Files Coverage Δ
...java/org/opensearch/knn/training/VectorReader.java 83.56% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83c88f...5b9e5eb. Read the comment docs.

jmazanec15
jmazanec15 previously approved these changes Jul 12, 2022
@prudhvigodithi
Copy link
Member Author

Closing this PR in favor of #442
As I have added backport labels 1.x

Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi
Copy link
Member Author

Reopening the PR, as I have noticed the backport will fail from main and for 1.x and 2.x the version increment files are different, for 1.x requires jni/CMakeLists.txt and build.gradle but for 2.x only build.gradle is required.

@prudhvigodithi
Copy link
Member Author

Renaming to task updateVersion following opensearch-project/opensearch-plugin-template-java#32.

@prudhvigodithi
Copy link
Member Author

Hey @jmazanec15 @vamshin can you please take a look.
Thank you

@prudhvigodithi
Copy link
Member Author

Hey @jmazanec15 @martin-gaievski if we good, can we proceed to merge this PR?
@bbarani

@jmazanec15 jmazanec15 merged commit 317acd1 into opensearch-project:1.x Jul 26, 2022
@prudhvigodithi
Copy link
Member Author

Hey @jmazanec15 @martin-gaievski, I dont see this is backported to 1.3 branch, can you please take a look?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 Backports PRs to 1.3 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants