Add mac platform to CI #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
============================================
+ Coverage 84.32% 84.51% +0.19%
- Complexity 1039 1054 +15
============================================
Files 148 149 +1
Lines 4222 4301 +79
Branches 373 382 +9
============================================
+ Hits 3560 3635 +75
- Misses 488 489 +1
- Partials 174 177 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
heemin32
approved these changes
Oct 25, 2022
| - name: Install dependencies on macos | ||
| if: startsWith(matrix.os, 'macos') | ||
| run: | | ||
| brew reinstall gcc |
There was a problem hiding this comment.
is this guaranteed that 'brew' is pre-installed on macos machines?
There was a problem hiding this comment.
Yes, atleast on all github hosted runners with macOS
martin-gaievski
approved these changes
Oct 25, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com> Signed-off-by: Naveen Tatikonda <navtat@amazon.com> (cherry picked from commit 5bb7a3f)
naveentatikonda
added
the
Infrastructure
naveentatikonda
added a commit
that referenced
this pull request
Oct 25, 2022
heemin32
added
2.4.0
v2.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda navtat@amazon.com
Description
Add macos platform to CI
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.