Add a fix to failing secured integration tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
reviewed
Mar 15, 2022
naveentatikonda
force-pushed
the
secured_integ_tests
branch
2 times, most recently
from
34b3a45
to
a0ad6d6
Compare
VijayanB
reviewed
Mar 15, 2022
jmazanec15
reviewed
Mar 15, 2022
lib/logstash/inputs/opensearch.rb
Outdated
| @@ -348,6 +350,8 @@ def hosts_default?(hosts) | |||
|
|
|||
| def setup_ssl | |||
| @ssl && @ca_file ? { :ssl => true, :ca_file => @ca_file } : {} | |||
| #@ssl && !@ca_file ? { :ssl => true, :verify => false } : {} | |||
| @ssl && !@ssl_certificate_verification ? { :ssl => true, :verify => false } : {} | |||
There was a problem hiding this comment.
Will line 352 ever be able to be returned?
There was a problem hiding this comment.
Yes, not from the tests but when the Cx provides ca_file path.
naveentatikonda
force-pushed
the
secured_integ_tests
branch
from
ec52b82
to
4ad0034
Compare
VijayanB
reviewed
Mar 28, 2022
VijayanB
reviewed
Mar 28, 2022
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
secured_integ_tests
branch
from
4ad0034
to
a1bfaea
Compare
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
VijayanB
reviewed
Mar 29, 2022
VijayanB
approved these changes
Mar 30, 2022
Shivamdhar
reviewed
Mar 30, 2022
Shivamdhar
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda navtat@amazon.com
Description
Fix the failing secured integration tests.
Issues Resolved
#16
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.