Namespace changes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivamdhar
reviewed
Feb 22, 2022
lib/logstash/inputs/opensearch/patches/_opensearch_transport_http_manticore.rb
Show resolved
Hide resolved
VijayanB
reviewed
Feb 22, 2022
VijayanB
reviewed
Feb 22, 2022
spec/inputs/opensearch_spec.rb
Outdated
| @@ -47,15 +47,15 @@ | |||
| end | |||
|
|
|||
| it_behaves_like "an interruptible input plugin" do | |||
| let(:esclient) { double("elasticsearch-client") } | |||
| let(:esclient) { double("opensearch-client") } | |||
There was a problem hiding this comment.
should we change "esclient" to something like "osclient"?
There was a problem hiding this comment.
@VijayanB would you like to comment
There was a problem hiding this comment.
I checked with Vijay offline, we can make it "opensearch_client" or "client". We can't update it to "osclient" as os stands for "operating system". To make it simple, I updated it to "client".
lib/logstash/inputs/opensearch/patches/_opensearch_transport_http_manticore.rb
Show resolved
Hide resolved
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
namespace_changes
branch
from
4dcabc8
to
7051785
Compare
naveentatikonda
requested review from
Shivamdhar,
martin-gaievski and
VijayanB
VijayanB
approved these changes
Feb 23, 2022
martin-gaievski
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda navtat@amazon.com
Description
Delete docs and make the following namespace changes:
Elasticsearch -> OpenSearch
ES -> OpenSearch
es -> opensearch
elasticsearch -> opensearch
Issues Resolved
#4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.