Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update husky to 8.0.3 to avoid use execa #160

Merged
merged 1 commit into from
May 23, 2023
Merged

chore: update husky to 8.0.3 to avoid use execa #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npx lint-staged
10 changes: 3 additions & 7 deletions package.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanglam I remember you mentioned before that if the package version different from the version of other plugins, the build will fail, that's why we use an old version of husky, is that still the case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The details is in this PR. The yarn osd bootstrap will be failed. We will clone many plugins in the development phase. For plugin build phase it always care about one plugin, i am not sure if the dependency install will be failed. I also find some different husky version in dashboards-observability and dashboards-query-workbench.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, if only one plugin is build at one time, I think that will not be an issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check with @peterzhuamazon about the different dev dependencies.

Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,13 @@
"plugin-helpers": "node ../../scripts/plugin_helpers",
"osd": "node ../../scripts/osd",
"lint:es": "node ../../scripts/eslint",
"test:jest": "../../node_modules/.bin/jest --config ./test/jest.config.js"
},
"husky": {
"hooks": {
"pre-commit": "lint-staged"
}
"test:jest": "../../node_modules/.bin/jest --config ./test/jest.config.js",
"prepare": "husky install"
},
"dependencies": {},
"devDependencies": {
"@testing-library/user-event": "^14.4.3",
"husky": "^3.0.0",
"husky": "^8.0.0",
"lint-staged": "^10.0.0"
}
}
Loading