fix no permission to update model group index (#948)

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
opensearch-project · Jun 1, 2023 · da5db17 · da5db17
1 parent d2b847e
commit da5db17
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/...n/src/main/java/org/opensearch/ml/action/model_group/TransportUpdateModelGroupAction.java b/...n/src/main/java/org/opensearch/ml/action/model_group/TransportUpdateModelGroupAction.java
@@ -140,14 +140,19 @@ private void updateModelGroup(
 
         UpdateRequest updateModelGroupRequest = new UpdateRequest();
         updateModelGroupRequest.index(ML_MODEL_GROUP_INDEX).id(modelGroupId).doc(source);
-        client
-            .update(
-                updateModelGroupRequest,
-                ActionListener.wrap(r -> { listener.onResponse(new MLUpdateModelGroupResponse("Updated")); }, e -> {
-                    log.error("Failed to update Model Group", e);
-                    throw new MLException("Failed to update Model Group", e);
-                })
-            );
+        try (ThreadContext.StoredContext context = client.threadPool().getThreadContext().stashContext()) {
+            client
+                .update(
+                    updateModelGroupRequest,
+                    ActionListener.wrap(r -> { listener.onResponse(new MLUpdateModelGroupResponse("Updated")); }, e -> {
+                        log.error("Failed to update Model Group", e);
+                        throw new MLException("Failed to update Model Group", e);
+                    })
+                );
+        } catch (Exception e) {
+            logException("Failed to Update model group ", e, log);
+            listener.onFailure(e);
+        }
     }
 
     private void validateRequestForAccessControl(MLUpdateModelGroupInput input, User user, MLModelGroup mlModelGroup) {