-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tool interface javadocs and generic types #1575
Fix Tool interface javadocs and generic types #1575
Conversation
Windows (17) test failure not associated with this PR:
Linux (11) test failure not associated with this PR:
|
04f5a20
to
aae1f0e
Compare
OK, I've updated the target branch, but then this just becomes a fixup of a few files. I expect that adding the generic types probably broke several committed POC files that implement the interfaces, though, so I'll have to update them now. How will these interfaces and the Agent Framework that uses them be made available for import by other projects?
At the moment I am trying to complete #1547 which is the CatIndices tool. But you have already written it on this branch. So what is the tasking for #1547? |
aae1f0e
to
3259b4e
Compare
Signed-off-by: Daniel Widdis <widdis@gmail.com>
3259b4e
to
f48aa69
Compare
Thanks @dbwiddis .
For development phase, we can use maven local. We will publish to maven central when release just like ml client.
For now the PoC is workable , we don't consider edge cases, permissions, testing etc. To make it prod ready, we need to fill the gap to make it robust, performant and secure. |
How are we tracking which classes on this branch have been "productionized"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7b9a1f2
into
opensearch-project:feature/agent_framework_dev
Description
Adds generic types to Tool interfaces
Issues Resolved
In support of #1161 , #1521, #1545, #1546, #1547, #1548
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.