Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tool interface javadocs and generic types #1575

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Oct 31, 2023

Description

Adds generic types to Tool interfaces

Issues Resolved

In support of #1161 , #1521, #1545, #1546, #1547, #1548

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis
Copy link
Member Author

Windows (17) test failure not associated with this PR:

46 tests completed, 1 failed, 9 skipped
Tests with failures:
 - org.opensearch.ml.rest.RestMemoryGetConversationsActionIT.testGetConversations_nextPage

Linux (11) test failure not associated with this PR:

765 tests completed, 1 failed, 55 skipped
Tests with failures:
 - org.opensearch.ml.action.prediction.PredictionITTests.testPredictionWithDataFrame_LinearRegression

@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env October 31, 2023 23:54 — with GitHub Actions Inactive
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env October 31, 2023 23:54 — with GitHub Actions Failure
@ylwu-amzn
Copy link
Collaborator

Hi, @dbwiddis we are developing agent framework in feature branch now, please cut PR to feature branch : feature/agent_framework_dev,

BTW, are you or @jngz-es working on tool framework now?

@dbwiddis dbwiddis changed the base branch from main to feature/agent_framework_dev November 1, 2023 00:15
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env November 1, 2023 00:31 — with GitHub Actions Failure
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env November 1, 2023 00:31 — with GitHub Actions Failure
@dbwiddis
Copy link
Member Author

dbwiddis commented Nov 1, 2023

Hi, @dbwiddis we are developing agent framework in feature branch now, please cut PR to feature branch : feature/agent_framework_dev,

OK, I've updated the target branch, but then this just becomes a fixup of a few files. I expect that adding the generic types probably broke several committed POC files that implement the interfaces, though, so I'll have to update them now.

How will these interfaces and the Agent Framework that uses them be made available for import by other projects?

BTW, are you or @jngz-es working on tool framework now?

At the moment I am trying to complete #1547 which is the CatIndices tool. But you have already written it on this branch. So what is the tasking for #1547?

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env November 1, 2023 00:45 — with GitHub Actions Failure
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env November 1, 2023 00:45 — with GitHub Actions Failure
@dbwiddis dbwiddis changed the title Add SPI subproject and interfaces for Tools Fix Tool interface javadocs and generic types Nov 1, 2023
@ylwu-amzn
Copy link
Collaborator

Thanks @dbwiddis .

How will these interfaces and the Agent Framework that uses them be made available for import by other projects?

For development phase, we can use maven local. We will publish to maven central when release just like ml client.

But you have already written it on this branch. So what is the tasking for #1547?

For now the PoC is workable , we don't consider edge cases, permissions, testing etc. To make it prod ready, we need to fill the gap to make it robust, performant and secure.

@dbwiddis
Copy link
Member Author

dbwiddis commented Nov 1, 2023

For now the PoC is workable , we don't consider edge cases, permissions, testing etc. To make it prod ready, we need to fill the gap to make it robust, performant and secure.

How are we tracking which classes on this branch have been "productionized"?

Copy link
Collaborator

@jngz-es jngz-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngz-es jngz-es merged commit 7b9a1f2 into opensearch-project:feature/agent_framework_dev Nov 1, 2023
2 of 6 checks passed
@dbwiddis dbwiddis deleted the tool-interfaces branch November 5, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants