Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ML task index mapping #2949

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix ML task index mapping #2949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions common/src/main/java/org/opensearch/ml/common/CommonValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,11 +391,10 @@ public class CommonValue {
+ " \""
+ MLTask.IS_ASYNC_TASK_FIELD
+ "\" : {\"type\" : \"boolean\"}, \n"
+ USER_FIELD_MAPPING
+ " }\n"
+ "}"
+ " \""
+ MLTask.REMOTE_JOB_FIELD
+ "\" : {\"type\": \"flat_object\"}\n"
+ "\" : {\"type\": \"flat_object\"}, \n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to keep the consistency with other fields may be we can add + " \"" after this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite get you, that will bring extra \" which will be a wrong index mapping

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the confusion. Please ignore my comment.

+ USER_FIELD_MAPPING
+ " }\n"
+ "}";

Expand Down
Loading