Fix last_updated_time not updating in model group updates #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
Signed-off-by: Yerzhaisang Taskali <tasqali1697@gmail.com>
Yerzhaisang
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
Yerzhaisang
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
Yerzhaisang
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
brianf-aws
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Looks good to me. Thanks!
Yerzhaisang
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
@Yerzhaisang In your example screenshot, I saw after model group creation request, created time and updated time are same which makes sense. But why after model group update request, still created time and updated time are same? Also why updated time didn't get updated? It looks same after creation and upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
After
Related Issues
#3408
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.