Fix time bounds in query to address indeterminism #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the millisecond granularity was causing bounds mismatch between 2 intervals * made the upper bound exclusive while fetching config to fix indeterminism Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
rishabhmaurya
force-pushed
the
rishma-windows-build
branch
from
7a9c757 to
c523abd
Compare
Angie-Zhang
approved these changes
Nov 8, 2022
lezzago
approved these changes
Nov 8, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
* the millisecond granularity was causing bounds mismatch between 2 intervals * made the upper bound exclusive while fetching config to fix indeterminism Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 63e5f13)
This was referenced Nov 8, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
* the millisecond granularity was causing bounds mismatch between 2 intervals * made the upper bound exclusive while fetching config to fix indeterminism Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 63e5f13)
rishabhmaurya
added a commit
that referenced
this pull request
Nov 9, 2022
* the millisecond granularity was causing bounds mismatch between 2 intervals * made the upper bound exclusive while fetching config to fix indeterminism Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 63e5f13) Co-authored-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
rishabhmaurya
added a commit
that referenced
this pull request
Nov 9, 2022
* the millisecond granularity was causing bounds mismatch between 2 intervals * made the upper bound exclusive while fetching config to fix indeterminism Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 63e5f13) Co-authored-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.